Fix Android APK signature corruption and install failures - #197
Conversation
- Update release.yml to use Debug configuration for unsigned builds. This ensures APKs are signed with a debug key for installability on forks. - Refine FixRuntimePackAssetTypes in osu.Android.props to reclassify all non-managed assets as 'native'. This prevents .NET 10 trimmer corruption of .so and other native files. - Improve signing security by moving secrets to environment variables in the release workflow and quoting command-line parameters. - This resolves the INSTALL_PARSE_FAILED_NO_CERTIFICATES error on modern Android devices (API 36).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes the
INSTALL_PARSE_FAILED_NO_CERTIFICATESerror encountered during Android APK installation, particularly on forks without private signing keys.Key changes:
Debugconfiguration when no signing keystore is provided. This leverages the .NET SDK's automatic debug-signing, producing an installable APK for testing.FixRuntimePackAssetTypestarget inosu.Android.propsto aggressively reclassify non-managed assets asnative. This prevents the .NET 10 trimmer from corrupting binary files (like BASS or the Oboe bridge) during the optimization phase, which previously invalidated the APK signature.These changes ensure compatibility with Android 16 (API 36) and .NET 10's stricter signature and trimming requirements.
PR created automatically by Jules for task 8415127907450049379 started by @winnerspiros